Skip to content

Allow dracut info logs to be visible for baremetal base image#7788

Merged
romoh merged 1 commit intomainfrom
user/romoh/baseimage-dracutlogs
Feb 8, 2024
Merged

Allow dracut info logs to be visible for baremetal base image#7788
romoh merged 1 commit intomainfrom
user/romoh/baseimage-dracutlogs

Conversation

@romoh
Copy link
Copy Markdown
Contributor

@romoh romoh commented Feb 8, 2024

Increase the verbosity to allow minimum level of debugging.
Note: Adding extra logging for dracut comes with a penalty on boot time, but it is a trade-off with debuggability. This is another reason why I didn't use rd.debug as it is more verbose and will make that worse.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
More verbose dracut logs

Change Log
  • Add kernel cmdline args
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: xxxx

@romoh romoh requested a review from a team as a code owner February 8, 2024 23:03
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Feb 8, 2024
@romoh romoh merged commit 5433c58 into main Feb 8, 2024
@romoh romoh deleted the user/romoh/baseimage-dracutlogs branch February 8, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants