Skip to content

Upgrade package skopeo to 0.14.2, to take Docker Daemon fix#7859

Merged
mfrw merged 1 commit intomicrosoft:mainfrom
dsteeley:dws/skopeo_0_14_2
Apr 23, 2024
Merged

Upgrade package skopeo to 0.14.2, to take Docker Daemon fix#7859
mfrw merged 1 commit intomicrosoft:mainfrom
dsteeley:dws/skopeo_0_14_2

Conversation

@dsteeley
Copy link
Copy Markdown
Contributor

@dsteeley dsteeley commented Feb 13, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

See containers/skopeo@v1.14.1...v1.14.2 for the details of the update.
0.14.2 fixes version compatibility issues with docker 25.0.0 onwards.

Change Log
  • Update skopeo to 0.14.2 resolving Docker Daemon issue
  • Change
  • Change
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: xxxx

@dsteeley dsteeley requested a review from a team as a code owner February 13, 2024 11:33
@dsteeley
Copy link
Copy Markdown
Contributor Author

dsteeley commented Feb 13, 2024

Please could I request that the skopeo 0.14.2 tarball be uploaded from https://github.com/containers/skopeo/releases/tag/v1.14.2 to https://cblmarinerstorage.blob.core.windows.net/sources/core/.
Once this is uploaded I should be able to test the build and checks.

mfrw
mfrw reviewed Feb 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please retarget this to 'main'

@dsteeley dsteeley changed the base branch from 2.0 to main February 13, 2024 12:20
@dsteeley dsteeley requested review from a team as code owners February 13, 2024 12:20
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Feb 13, 2024
@mfrw
Copy link
Copy Markdown
Member

mfrw commented Feb 13, 2024

Please could I request that the skopeo 0.14.2 tarball be uploaded from https://github.com/containers/skopeo/releases/tag/v1.14.2 to https://cblmarinerstorage.blob.core.windows.net/sources/core/. Once this is uploaded I should be able to test the build and checks.

Pipeline triggered. link

mfrw
mfrw reviewed Feb 13, 2024
View reviewed changes
Comment thread SPECS/skopeo/skopeo.spec
%{_mandir}/man1/%%{name}*

%changelog
* Tue Feb 13 2024 David Steele <davidsteele@microsoft.com> - 1.14.2-1
Copy link
Copy Markdown
Member

@mfrw mfrw Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test build: PR-7859

Copy link
Copy Markdown
Contributor Author

@dsteeley dsteeley Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfrw that pipeline has passed. Do you require anything more from me to get this PR merged?

Copy link
Copy Markdown
Member

@mfrw mfrw Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for a review from one of the stable maintainers.
/cc @jslobodzian @christopherco

Copy link
Copy Markdown
Contributor Author

@dsteeley dsteeley Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump on this @jslobodzian / @christopherco. Could you please review?

Copy link
Copy Markdown

@RocketJas RocketJas Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is is this MR ready to go @jslobodzian / @christopherco ?

mfrw
mfrw approved these changes Apr 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfrw mfrw merged commit 702c88a into microsoft:main Apr 23, 2024
amritakohli pushed a commit that referenced this pull request May 2, 2024
@dsteeley @mfrw @amritakohli
skopeo: upgrade 0.14.1 -> 0.14.2 to include Docker Daemon fix (#7859)
7ec2b4d 
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfrw mfrw mfrw approved these changes

+1 more reviewer

@RocketJas RocketJas RocketJas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

main PR Destined for main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsteeley @mfrw @RocketJas