[2.0] dhcp/dhclient.conf: add option rfc3442-classless-static-routes in dhclient.conf#8318
Merged
ddstreetmicrosoft merged 1 commit intomicrosoft:mainfrom Mar 13, 2024
Merged
Conversation
cjp256
changed the title
cjp256
changed the title
mfrw
reviewed
Mar 11, 2024
Member
mfrw
left a comment
mfrw
left a comment
There was a problem hiding this comment.
Can we please retarget this change to main.
Anything that has to go to 2.0 goes via main :)
Azure configures classless routes and cloud-init requires the configuration to be included in the lease file to behave correctly. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Contributor
Author
|
Fixes #8334 |
Contributor
Author
Done, thanks! |
ddstreetmicrosoft
approved these changes
Mar 11, 2024
Contributor
ddstreetmicrosoft
left a comment
ddstreetmicrosoft
left a comment
There was a problem hiding this comment.
Thanks for #8334, it clearly explains the issue and after reading that this LGTM
We should add this to 3.0 as well, can you open a PR against 3.0-dev also?
anhvoms
approved these changes
Mar 11, 2024
dmcilvaney
approved these changes
Mar 11, 2024
Contributor
dmcilvaney
left a comment
dmcilvaney
left a comment
There was a problem hiding this comment.
Cleaned up some spurious required reviews (probably a leftover from 2.0 target). Dropped tooling and admins. That said I don't see any issues with the change.
ddstreetmicrosoft
pushed a commit
that referenced
this pull request
Mar 13, 2024
…in dhclient.conf (#8318) Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
ddstreetmicrosoft
pushed a commit
that referenced
this pull request
Mar 22, 2024
…in dhclient.conf (#8318) Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Azure configures classless routes and cloud-init requires the configuration to be included in the lease file to behave correctly.
Change Log
Does this affect the toolchain?
No
Test Methodology
Build & installed RPM locally and validated cloud-init behavior.