imagecustomizer: Optimize MIC Overlay supporting multiple volumes.#8332
Merged
imagecustomizer: Optimize MIC Overlay supporting multiple volumes.#8332
Conversation
Adub17030MS
suggested changes
Mar 11, 2024
cwize1
approved these changes
Mar 12, 2024
Adub17030MS
approved these changes
Mar 12, 2024
dmcilvaney
reviewed
Mar 12, 2024
| # Check if /etc/mdadm.conf exists. | ||
| if [ -f "/etc/mdadm.conf" ]; then | ||
| mdadm --assemble ${partition} || \ | ||
| mdadm --assemble ${_volume} || \ |
Contributor
There was a problem hiding this comment.
Not needed to fix here, but dracut should already be able to assemble mdadm raid on its own. If you add an entry to the init queue to wait for it I think that should work?
Contributor
Author
There was a problem hiding this comment.
Mark here, thanks.
dmcilvaney
approved these changes
Mar 12, 2024
This was referenced Mar 13, 2024
BettyRain
pushed a commit
that referenced
this pull request
Mar 13, 2024
…8332) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
liulanze
added a commit
that referenced
this pull request
Mar 21, 2024
…8332) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
liulanze
added a commit
that referenced
this pull request
Apr 2, 2024
…8332) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
12 tasks
Xiaohong-Deng
pushed a commit
to Xiaohong-Deng/azurelinux
that referenced
this pull request
Nov 23, 2024
…icrosoft#8332) Co-authored-by: lanzeliu <lanzeliu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Summary
What does the PR accomplish, why was it needed?
Optimize the existing MIC Overlay API to support multiple volumes. Users can assign different persistent volumes to distinct Overlays. If no volumes are set, a volatile Overlay will be created.
Does this affect the toolchain?
NO
Associated issues
Test Methodology