Skip to content

Bump golang version to 1.21.8-1, build version to 1.21.8-2#8500

Merged
dagood merged 1 commit intomicrosoft:3.0-devfrom
dagood:dev/dagood/go-1.21.8-2
Mar 22, 2024
Merged

Bump golang version to 1.21.8-1, build version to 1.21.8-2#8500
dagood merged 1 commit intomicrosoft:3.0-devfrom
dagood:dev/dagood/go-1.21.8-2

Conversation

@dagood
Copy link
Copy Markdown
Member

@dagood dagood commented Mar 21, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Bump golang version to 1.21.8-1, build version to 1.21.8-2

Change Log
  • Thu Mar 21 2024 Davis Goodin - 1.21.8-1
    • Bump version to 1.21.8-1, build version to 1.21.8-2
Does this affect the toolchain?

No

Links to CVEs
Test Methodology

@dagood dagood marked this pull request as ready for review March 21, 2024 18:40
@dagood dagood requested a review from a team as a code owner March 21, 2024 18:40
@dagood dagood mentioned this pull request Mar 21, 2024
12 tasks
@mfrw mfrw added the 3.0-dev PRs Destined for AzureLinux 3.0 label Mar 22, 2024
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread SPECS/golang/golang.spec
%global ms_go_revision 1
%global ms_go_buildid 20240111.3
%global ms_go_revision 2
%global ms_go_buildid 20240320.5
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move to 20240321.6 which is the most recent release with updated submodules ?

Copy link
Copy Markdown
Member Author

@dagood dagood Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule and patches are the same in source control, and the src tarball content is showing up as 100% identical according to kdiff3 on Windows.

We only ran 1.21.8-3 (and 1.22.1-3) to exercise our 1ES pipeline template migration backports. Using it is perfectly fine, but not necessary. (Updated release note.)

@dagood dagood merged commit 7b9c355 into microsoft:3.0-dev Mar 22, 2024
@dagood dagood deleted the dev/dagood/go-1.21.8-2 branch March 22, 2024 16:47
Xiaohong-Deng pushed a commit to Xiaohong-Deng/azurelinux that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants