Skip to content

Upgrade expat to 2.6.2 CVE-2023-52425 and CVE-2024-28757#8507

Merged
PawelWMS merged 14 commits intofasttrack/2.0from
adityadubey/expatCVEfix
Mar 26, 2024
Merged

Upgrade expat to 2.6.2 CVE-2023-52425 and CVE-2024-28757#8507
PawelWMS merged 14 commits intofasttrack/2.0from
adityadubey/expatCVEfix

Conversation

@Adub17030MS
Copy link
Copy Markdown
Contributor

@Adub17030MS Adub17030MS commented Mar 21, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Upgrading to 2.6.2 to fix CVE-2023-52425. This also fixes CVE-2024-28757.

libexpat through 2.6.1 allows an XML Entity Expansion attack when there is isolated use of external parsers (created via
XML_ExternalEntityParserCreate). Affected packages: cmake, python3, and expat.

Upgrading expat solves the issue for the 3 packages

Change Log
  • Upgraded package to version 2.6.2
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Buddy build id: link
  • Passed PR pipeline build check

@Adub17030MS Adub17030MS changed the title package upgrade for CVE fix Upgrade expat to 2.6.2 CVE-2024-28757 Mar 21, 2024
@Adub17030MS Adub17030MS changed the title Upgrade expat to 2.6.2 CVE-2024-28757 Upgrade expat to 2.6.2 CVE-2023-52425 and CVE-2024-28757 Mar 21, 2024
@Adub17030MS Adub17030MS marked this pull request as ready for review March 21, 2024 22:51
@Adub17030MS Adub17030MS requested a review from a team as a code owner March 21, 2024 22:51
@alejandro-microsoft
Copy link
Copy Markdown
Contributor

Same fix forCVE-2024-28757: libexpat through 2.6.1 allows an XML Entity Expansion attack when there is isolated use of external parsers (created via XML_ExternalEntityParserCreate). Affected packages:
cmake
, python3
, and expat. Upgrading expat solves issue for the 3 packages.

Comment thread SPECS/expat/expat.spec Outdated
Comment thread SPECS/expat/expat.spec
@Adub17030MS Adub17030MS marked this pull request as draft March 25, 2024 18:30
@Adub17030MS Adub17030MS marked this pull request as ready for review March 26, 2024 20:13
@PawelWMS
Copy link
Copy Markdown
Contributor

Pre-rebase change built and tested without issues. The rebase didn't introduce any changes related to the bits modified in this PR - merging.

@PawelWMS PawelWMS merged commit ba2e503 into fasttrack/2.0 Mar 26, 2024
@PawelWMS PawelWMS deleted the adityadubey/expatCVEfix branch March 26, 2024 21:14
CBL-Mariner-Bot pushed a commit that referenced this pull request Mar 26, 2024
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants