Skip to content

explicitly add libgcc as a Requires to distroless base#8538

Merged
mandeepsplaha merged 1 commit intomainfrom
mandeepsplaha/add-libgcc-explicitly-to-distroless-base
Mar 25, 2024
Merged

explicitly add libgcc as a Requires to distroless base#8538
mandeepsplaha merged 1 commit intomainfrom
mandeepsplaha/add-libgcc-explicitly-to-distroless-base

Conversation

@mandeepsplaha
Copy link
Copy Markdown
Contributor

@mandeepsplaha mandeepsplaha commented Mar 25, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This PR adds libgcc package explictly as a runtime dependency for distroless/base subpackage to ensure that the distroless/base container image continues to have it. Currently, libgcc is brought it by some other package as its dependency. It was observed that the changes in Azure Linux 3.0 had resulted in the removal of libgcc package from distroless base, so it was explictly added to not cause a breaking change. For reference, this is the merged PR in Azure Linux 3.0: #8520.

Change Log

Package: distroless-packages-base

Does this affect the toolchain?

NO

Test Methodology

This is considered a non-breaking change as we are just explicitly including libgcc as a runtime dependency; it is already present due to some other package.

Azure Linux 2.0 distroless/debug
busybox
distroless-packages-base
distroless-packages-debug
distroless-packages-minimal
filesystem
glibc
glibc-iconv
iana-etc
libgcc
mariner-release
openssl
openssl-libs
prebuilt-ca-certificates
tzdata

@mandeepsplaha mandeepsplaha requested a review from a team as a code owner March 25, 2024 18:01
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Mar 25, 2024
@mandeepsplaha mandeepsplaha merged commit 4611598 into main Mar 25, 2024
@mandeepsplaha mandeepsplaha deleted the mandeepsplaha/add-libgcc-explicitly-to-distroless-base branch March 25, 2024 18:23
mandeepsplaha added a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants