explicitly add libgcc as a Requires to distroless base#8538
Merged
mandeepsplaha merged 1 commit intomainfrom Mar 25, 2024
Merged
Conversation
jslobodzian
approved these changes
Mar 25, 2024
anphel31
approved these changes
Mar 25, 2024
mandeepsplaha
added a commit
that referenced
this pull request
Apr 1, 2024
This reverts commit 4611598.
mandeepsplaha
added a commit
that referenced
this pull request
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
This PR adds
libgccpackage explictly as a runtime dependency for distroless/base subpackage to ensure that the distroless/base container image continues to have it. Currently,libgccis brought it by some other package as its dependency. It was observed that the changes in Azure Linux 3.0 had resulted in the removal oflibgccpackage from distroless base, so it was explictly added to not cause a breaking change. For reference, this is the merged PR in Azure Linux 3.0: #8520.Change Log
Package:
distroless-packages-baseDoes this affect the toolchain?
NO
Test Methodology
This is considered a non-breaking change as we are just explicitly including
libgccas a runtime dependency; it is already present due to some other package.