Skip to content

Cython: skip long tests#8546

Merged
anphel31 merged 2 commits intomainfrom
anphel/main-cython-ptest-speedup
Mar 25, 2024
Merged

Cython: skip long tests#8546
anphel31 merged 2 commits intomainfrom
anphel/main-cython-ptest-speedup

Conversation

@anphel31
Copy link
Copy Markdown
Member

@anphel31 anphel31 commented Mar 25, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Cython package tests take over 3 hours to run in our ptest pipelines (link). Disable long-running file and examples tests to ensure the tests can complete in a reasonable amount of time.

Change Log
  • Change Cython tests to skip long-running tests
Does this affect the toolchain?

YES

Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Mar 25, 2024
@anphel31 anphel31 marked this pull request as ready for review March 25, 2024 21:35
@anphel31 anphel31 requested a review from a team as a code owner March 25, 2024 21:35
@anphel31 anphel31 merged commit 392fadb into main Mar 25, 2024
@anphel31 anphel31 deleted the anphel/main-cython-ptest-speedup branch March 25, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants