Add configurability in systemd to control default value of UseDomains parameter#8741
Add configurability in systemd to control default value of UseDomains parameter#8741henryli001 merged 6 commits intomainfrom
Conversation
|
technically looks ok, but these kind of user-facing parameters are dangerous to add into stable releases before upstreaming; we do not want to add and release a config param that our users start using, and then have upstream decide they want to do it differently, leaving us to clean up our own mess of having a parameter that (at best) is confusing to end users and adds maintenance burden or (at worst) directly conflicts with how upstream decides to implement it. So with the caveat that this needs to be upstreamed first, it LGTM. |
Makes sense to me. Will start working on the upstream change first and post the link here. |
Upstream changes have been merged in: systemd/systemd#32194. Updated the patch here to align with the upstream changes. |
ddstreetmicrosoft
left a comment
There was a problem hiding this comment.
LGTM but please patch azl3 also (preferably first)
3.0 patching complete. Here's the PR link: #8799 |
… parameter (#8741) Co-authored-by: Henry Li <lihl@microsoft.com>
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
NO
Test Methodology