Skip to content

Fixed CODEOWNERS group for certificates.#8895

Merged
PawelWMS merged 1 commit intomainfrom
pawelwi/add_certificate_owners
May 9, 2024
Merged

Fixed CODEOWNERS group for certificates.#8895
PawelWMS merged 1 commit intomainfrom
pawelwi/add_certificate_owners

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Adding the missing group from #8859.

Does this affect the toolchain?

No.

Test Methodology
  • Local tests with .gitignore.

@PawelWMS PawelWMS requested a review from a team as a code owner April 24, 2024 20:17
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Apr 24, 2024
@PawelWMS PawelWMS changed the title Fixing groups. Fixed CODEOWNERS group for certificates. Apr 24, 2024
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PawelWMS PawelWMS merged commit fa32acd into main May 9, 2024
@PawelWMS PawelWMS deleted the pawelwi/add_certificate_owners branch May 9, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants