Skip to content

dhcp: fix CVE-2022-38177, CVE-2022-38178, CVE-2022-2795 for bind#8971

Merged
elainezhao1 merged 13 commits intofasttrack/2.0from
elaine/dhcp
May 14, 2024
Merged

dhcp: fix CVE-2022-38177, CVE-2022-38178, CVE-2022-2795 for bind#8971
elainezhao1 merged 13 commits intofasttrack/2.0from
elaine/dhcp

Conversation

@elainezhao1
Copy link
Copy Markdown
Contributor

@elainezhao1 elainezhao1 commented Apr 30, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • [] Ready to merge

Summary

fix CVE-2023-50387, CVE-2022-38178, CVE-2022-2795 for bind in dhcp

Change Log
  • add patches
Does this affect the toolchain?

NO

Associated issues
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2022-38177
https://nvd.nist.gov/vuln/detail/CVE-2022-38178
https://nvd.nist.gov/vuln/detail/CVE-2022-2795

Test Methodology

@elainezhao1 elainezhao1 changed the title bind: fix CVE-2023-50387, CVE-2022-38178, CVE-2022-2795 dhcp: fix CVE-2023-50387, CVE-2022-38178, CVE-2022-2795 for bundled bind May 2, 2024
@elainezhao1 elainezhao1 changed the title dhcp: fix CVE-2023-50387, CVE-2022-38178, CVE-2022-2795 for bundled bind dhcp: fix CVE-2022-38177, CVE-2022-38178, CVE-2022-2795 for bundled bind May 2, 2024
@elainezhao1 elainezhao1 force-pushed the elaine/dhcp branch 2 times, most recently from 6d60efe to 6200e65 Compare May 6, 2024 20:26
@elainezhao1 elainezhao1 marked this pull request as ready for review May 6, 2024 20:52
@elainezhao1 elainezhao1 requested a review from a team as a code owner May 6, 2024 20:52
@elainezhao1
Copy link
Copy Markdown
Contributor Author

elainezhao1 commented May 6, 2024

getting error in Verify all tests passed in pr check https://dev.azure.com/mariner-org/mariner/_build/results?buildId=564240&view=ms.vss-test-web.build-test-results-tab&runId=193405&resultId=100000&paneView=attachments , error: could not connect to libvirt (URI = qemu:///system): Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory [code=38 int1=2]"

Comment thread SPECS/dhcp/dhcp.spec Outdated
@elainezhao1 elainezhao1 changed the title dhcp: fix CVE-2022-38177, CVE-2022-38178, CVE-2022-2795 for bundled bind dhcp: fix CVE-2022-38177, CVE-2022-38178, CVE-2022-2795 for bind May 7, 2024
Copy link
Copy Markdown
Contributor

@arc9693 arc9693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfrw mfrw added security fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels May 7, 2024
Comment thread SPECS/dhcp/dhcp.spec

%prep
%autosetup -p1
%setup -q -n dhcp-%{version}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious why you had to revert back to %setup and realized I've made a mistake in my initial suggestion by forgetting about the -N flag to disable auto patching. I've tested this to work locally:

Suggested change
%setup -q -n dhcp-%{version}
%autosetup -N

Sorry for the trouble.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation about %autosetup if you're curious: https://rpm-software-management.github.io/rpm/manual/autosetup.html.

Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small request for %autosetup but not a blocker.

@elainezhao1 elainezhao1 merged commit a2d7f53 into fasttrack/2.0 May 14, 2024
@elainezhao1 elainezhao1 deleted the elaine/dhcp branch May 14, 2024 06:55
CBL-Mariner-Bot pushed a commit that referenced this pull request May 14, 2024
Co-authored-by: Pawel Winogrodzki <pawelwi@microsoft.com>
(cherry picked from commit a2d7f53)
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fasttrack/2.0 PRs Destined for Azure Linux 2.0 security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants