Add new package: Mosh to spec-extended#8976
Merged
christopherco merged 16 commits intomicrosoft:mainfrom Aug 21, 2024
AZaugg:mosh-package
Merged
Add new package: Mosh to spec-extended#8976christopherco merged 16 commits intomicrosoft:mainfrom AZaugg:mosh-package
christopherco merged 16 commits intomicrosoft:mainfrom
AZaugg:mosh-package
Conversation
ChrisCarini
approved these changes
May 1, 2024
Member
ChrisCarini
left a comment
ChrisCarini
left a comment
There was a problem hiding this comment.
Excited to see this land! 🎉
rlmenge
reviewed
May 2, 2024
Contributor
rlmenge
left a comment
rlmenge
left a comment
There was a problem hiding this comment.
Started a buddy build here :) https://dev.azure.com/mariner-org/mariner/_build/results?buildId=561938&view=results
mfrw
reviewed
May 6, 2024
| @@ -0,0 +1,99 @@ | |||
| Name: mosh | |||
| Version: 1.4.0 | |||
| Release: 1%{?dist} | |||
Member
There was a problem hiding this comment.
A few of the PR checks are failing.
Contributor
|
Unblocked the PR checks and started a new buddy build https://dev.azure.com/mariner-org/mariner/_build/results?buildId=566882&view=results |
Adding a new package: mosh from fedora to spec-extended
adding explicit packages glibc-devel binutils kernel-headers
Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
spec actually comes from upstream mosh project under its "fedora" folder. Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
Signed-off-by: Chris Co <chrco@microsoft.com>
PawelWMS
reviewed
Aug 14, 2024
Comment on lines
+1
to
+6
| Name: mosh | ||
| Version: 1.4.0 | ||
| Release: 6%{?dist} | ||
| Summary: Mobile shell that supports roaming and intelligent local echo | ||
| Vendor: Microsoft Corporation | ||
| Distribution: Mariner |
Contributor
There was a problem hiding this comment.
Could you only replace tabs with spaces? Or at least it looks like these are tabs.
PawelWMS
approved these changes
Aug 14, 2024
Contributor
PawelWMS
left a comment
PawelWMS
left a comment
There was a problem hiding this comment.
Looks good, just a small request to use spaces instead of tabs.
Signed-off-by: Chris Co <chrco@microsoft.com>
christopherco
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Getting more than than a few requests for mariner to have the package mosh added, adding it to specs-extended
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology