Skip to content

Update facter version to support Mariner#9028

Merged
christopherco merged 2 commits intomicrosoft:mainfrom
AZaugg:facter-mariner
May 15, 2024
Merged

Update facter version to support Mariner#9028
christopherco merged 2 commits intomicrosoft:mainfrom
AZaugg:facter-mariner

Conversation

@AZaugg
Copy link
Copy Markdown
Contributor

@AZaugg AZaugg commented May 7, 2024

Minimum version of facter that supports Mariner facts.
https://puppet.atlassian.net/browse/FACT-3142

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • Ready to merge

Summary

The version of facter that currently ships with Mariner does not set the correct facts. Bumping the version to the minimum supported version that will expose the correct Mariner facts for puppet

Change Log
  • Bump version of facter to 3.2.13
Does this affect the toolchain?

NO

Test Methodology
  • Was hoping to use buddy build system to test

Minimum version of facter that supports Mariner facts.
https://puppet.atlassian.net/browse/FACT-3142
@AZaugg AZaugg requested a review from a team as a code owner May 7, 2024 16:51
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label May 7, 2024
Comment thread SPECS-EXTENDED/facter/facter.spec Outdated
Comment thread SPECS-EXTENDED/facter/facter.signatures.json Outdated
Comment thread SPECS-EXTENDED/facter/facter.spec Outdated
@christopherco
Copy link
Copy Markdown
Collaborator

@christopherco christopherco merged commit 35d5f54 into microsoft:main May 15, 2024
christopherco added a commit to christopherco/CBL-Mariner that referenced this pull request May 21, 2024
The version of facter that currently ships with Mariner does not set the correct facts. Bumping the version to the minimum supported version that will expose the correct Mariner facts for puppet

Co-authored-by: Christopher Co <35273088+christopherco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants