Update facter version to support Mariner#9028
Merged
christopherco merged 2 commits intomicrosoft:mainfrom May 15, 2024
AZaugg:facter-mariner
Merged
Update facter version to support Mariner#9028christopherco merged 2 commits intomicrosoft:mainfrom AZaugg:facter-mariner
christopherco merged 2 commits intomicrosoft:mainfrom
AZaugg:facter-mariner
Conversation
Minimum version of facter that supports Mariner facts. https://puppet.atlassian.net/browse/FACT-3142
christopherco
requested changes
May 13, 2024
Collaborator
christopherco
approved these changes
May 15, 2024
christopherco
added a commit
to christopherco/CBL-Mariner
that referenced
this pull request
May 21, 2024
The version of facter that currently ships with Mariner does not set the correct facts. Bumping the version to the minimum supported version that will expose the correct Mariner facts for puppet Co-authored-by: Christopher Co <35273088+christopherco@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimum version of facter that supports Mariner facts.
https://puppet.atlassian.net/browse/FACT-3142
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
The version of facter that currently ships with Mariner does not set the correct facts. Bumping the version to the minimum supported version that will expose the correct Mariner facts for puppet
Change Log
Does this affect the toolchain?
NO
Test Methodology