Sanitize licenses in core image packages #9147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
As part of #8776 we would like to disable documentation on specific size-constrained images. However, there is a complication: many packages do not use the
%licensetag in their%filessection to accurately tag license files. If such an image was distributed it would run afoul of open source licensing requirements (ie it would not include the required license files with the corresponding binary files). A tool was created that attempts to detect these cases (early draft here: #9060) and will be integrated into the normal build flow in the future.In the mean time, to unblock the configurable documentation PR, the packages which both apear in the no-documentation images, and have critical license issues, are fixed in this PR.
/usr/doc/cmake-3.28/<subproject>/*into the already usedLicensesfolder. It turns out these license files were the only documentation included in our package, so remove the empty dir.COPYINGwas being manually copied/renamed into/usr/share/licenses/%{name}/LICENSEduring install, and was marked as a normal file. The package already uses the%licensetag on the original file directly.COPYINGout of the%docsection into%license.%docand%licenseon the originals instead.make installstep places a concatenated license file into/usr/share/docs/librdkafka/LICENSES.txt, clean that up and use the%licensemacro instead.LICENSEin the base package,lmdb-libsis a requirement and already had them. Use%license.qemu-guest-agent,qemu-commonalready has all of them listed.make installplaces a LICENSE file, use the local copy with%licenseinstead. It should be in the core package, notuserspace-rcu-develas well.Change Log
Does this affect the toolchain?
YES
Associated issues
Test Methodology