Skip to content

Upgrade default golang to 1.22.5 and backport the fix for 1.18#9958

Merged
jslobodzian merged 3 commits intofasttrack/2.0from
bhagya/golang-CVE2024-24790
Jul 30, 2024
Merged

Upgrade default golang to 1.22.5 and backport the fix for 1.18#9958
jslobodzian merged 3 commits intofasttrack/2.0from
bhagya/golang-CVE2024-24790

Conversation

@bhagyapathak
Copy link
Copy Markdown
Contributor

@bhagyapathak bhagyapathak commented Jul 29, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [x ] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [ x] The toolchain/worker package manifests are up-to-date
  • [ x] Any updated packages successfully build (or no packages were changed)
  • [ x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [ x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [ x] All package sources are available
  • [ x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [ x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [ x] All source files have up-to-date hashes in the *.signatures.json files
  • [ x] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [ x] Documentation has been updated to match any changes to the build system
  • [ x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • Ready to merge

Summary

This PR fixes the CVE 2024-24790 in golang

Change Log

Upgrade golang 1.21 to 1.22
Backport fix to golang 1.18

Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-24790

Test Methodology

Local build successful

@bhagyapathak bhagyapathak requested a review from a team as a code owner July 29, 2024 13:17
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
[It was discussed offline that we would not bump the dependent packages]

/cc @jslobodzian

@mfrw mfrw self-requested a review July 29, 2024 13:36
Comment thread SPECS/golang/golang.spec
@mfrw mfrw added security fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Jul 29, 2024
@bhagyapathak bhagyapathak requested a review from mfrw July 29, 2024 13:44
@jslobodzian jslobodzian merged commit 82621dc into fasttrack/2.0 Jul 30, 2024
@jslobodzian jslobodzian deleted the bhagya/golang-CVE2024-24790 branch July 30, 2024 02:31
CBL-Mariner-Bot pushed a commit that referenced this pull request Jul 30, 2024
Test results are nominal.  Accepting PR change

(cherry picked from commit 82621dc)
@CBL-Mariner-Bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fasttrack/2.0 PRs Destined for Azure Linux 2.0 security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants