Backport: Update toolkit's gonum to v0.15.0#9965
Merged
dmcilvaney merged 2 commits intomicrosoft:mainfrom Aug 6, 2024
Merged
Conversation
dmcilvaney
force-pushed
the
damcilva/2.0/tools/backport_update_gonum
branch
from
2248b12 to
faefec0
Compare
mfrw
reviewed
Jul 30, 2024
| @@ -1,5 +1,5 @@ | |||
| filesystem-1.1-20.cm2.aarch64.rpm | |||
| kernel-headers-5.15.162.2-1.cm2.noarch.rpm | |||
| kernel-headers-5.15.160.1-1.cm2.noarch.rpm | |||
Member
There was a problem hiding this comment.
I think this maybe a typo .. changing the manifests.
Contributor
Author
There was a problem hiding this comment.
Trying to figure out why, I ran two cherry-pick commands on the two PRs... But yes this is unintended.
Contributor
Author
There was a problem hiding this comment.
Ok, fixed the commit
dmcilvaney
force-pushed
the
damcilva/2.0/tools/backport_update_gonum
branch
from
faefec0 to
922051d
Compare
mfrw
approved these changes
Jul 30, 2024
jslobodzian
reviewed
Aug 6, 2024
|
|
||
| env: | ||
| EXPECTED_GO_VERSION: "1.20" | ||
| EXPECTED_GO_VERSION: "1.21" |
Collaborator
There was a problem hiding this comment.
Do we need to bump this?
Contributor
Author
There was a problem hiding this comment.
Unfortunately yes, one of the libraries has a hard requirement on it.
jslobodzian
approved these changes
Aug 6, 2024
corvus-callidus
pushed a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: Sam Meluch <109628994+sameluch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Backport of #9784 and #9943
Change Log
Does this affect the toolchain?
NO
Associated issues
Test Methodology
sudo make image CONFIG_FILE=./imageconfigs/core-efi.json QUICK_REBUILD_PACKAGES=ywith2.0-stable manifests.https://dev.azure.com/mariner-org/mariner/_build/results?buildId=613810&view=resultshttps://dev.azure.com/mariner-org/mariner/_build/results?buildId=614184&view=results