Add coverage badges #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 20, 2023 13:54
Author
|
@microsoft-github-policy-service agree |
Author
|
@christianpaquin I am not sure this will work with the matrix you have. Do you want me to make a separate yaml file for coverage, and pin the node version? |
OR13
commented
Mar 20, 2023
| - run: npm install | ||
| - run: npm run build --if-present | ||
| - run: npm test | ||
| - run: npm run coverage |
Author
There was a problem hiding this comment.
may need to move this to a separate file...
Contributor
There was a problem hiding this comment.
we'll see; let's try it. Looks like CI ran correctly but badge fail because of branch permission; it might succeed on main (let's see)
OR13
commented
Mar 20, 2023
| *WORK IN PROGRESS* | ||
|
|
||
| [](https://github.com/microsoft/bbs-node-reference/actions/workflows/nodejs-ci.yml) | ||
|  |
Author
There was a problem hiding this comment.
The action will create this directory on main, and store latest badge details in it.
christianpaquin
approved these changes
Mar 20, 2023
Contributor
christianpaquin
left a comment
christianpaquin
left a comment
There was a problem hiding this comment.
Great, thanks @OR13
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will need to give the action permission to write to main:
Settings > Actions > General
I am not sure if this will work with the matrix approach you have for tests