You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
When we send outgoing activities in the adapter for http flows, if they fail, we let the exception get thrown so that it reaches the top level adapter. Cloud adapter+ streaming also does not catch, so that errors flow to the handlers.
However, outgoing activities on streaming when using the BotFrameworkHttpAdapter, we do catch the exceptions, log them and return null. The result is negative in a number of ways:
1- Errors are swallowed
2- Callers cannot retry or handler errors in code
3- Developers expect OnError trigger to get called but when using streaming it does not (OneVoice ran in to this)
This change makes all outgoing activities treat errors consistently (by not hiding them) and solve the problems above.
Please review and, if necessary, port the changes.
The changes in Streaming: Surface exceptions like other paths to allow error handling in upper layers. (#5803) may need to be ported to maintain parity with
microsoft/botbuilder-dotnet.Please review and, if necessary, port the changes.