Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

port: [Debugger] add injectable transport, with unit tests (#4921) #884

@github-actions

Description

@github-actions

The changes in [Debugger] add injectable transport, with unit tests (#4921) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

## Description This PR allows the debugger transport to be injectable to 1. simplify the debug adapter code 2. remove implementation inheritance 3. allow unit tests (with mocked transports) for the debug adapter code

Specific Changes

  • create new IDebugTransport interface
  • move code to use IDebugTransport interface
  • add first substantial unit test for debug adapter

Testing

Yep.

Please review and, if necessary, port the changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.needs-triageThe issue has just been created and it has not been reviewed by the team.parityThe issue describes a gap in parity between two or more platforms.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions