This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Update to pick up correct SDK version #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabog
approved these changes
Jan 4, 2022
LeeParrishMSFT
added a commit
that referenced
this pull request
Jan 4, 2022
* Update to pick up correct SDK version * Fix unit test in QnAMaker and spelling in comment. Co-authored-by: Gabo Gilabert <gabog@users.noreply.github.com>
tracyboehrer
pushed a commit
that referenced
this pull request
Jan 5, 2022
* Bump log4j-core from 2.17.0 to 2.17.1 (#1406) Bumps log4j-core from 2.17.0 to 2.17.1. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump log4j-api from 2.17.0 to 2.17.1 (#1405) Bumps log4j-api from 2.17.0 to 2.17.1. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-api dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update to pick up correct SDK version (#1404) * Update to pick up correct SDK version * Fix unit test in QnAMaker and spelling in comment. Co-authored-by: Gabo Gilabert <gabog@users.noreply.github.com> * Update version to 4.14.2 Bump log4j-core from 2.17.0 to 2.17.1 (#1406) Bumps log4j-core from 2.17.0 to 2.17.1. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update spring-core and spring-boot packages. (#1408) Co-authored-by: Gabo Gilabert <gabog@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gabo Gilabert <gabog@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1403
Description
Update to pick up correct SDK version and add it to the UserAgent string for metrics collection.
Specific Changes
Updated to get the version property from the project.properties file instead of the connector.properties file which isn't available.
Testing
Unit tests were run to validate that desired value was being returned from modified code.