Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptive library - recognizers#4067

Merged
mrivera-ms merged 4 commits intomainfrom
southworks/fix/eslint/botbuilder-dialogs-adaptive/recognizers
Feb 1, 2022
Merged

fix: [#2745] Fix current eslint warnings - botbuilder-dialogs-adaptive library - recognizers#4067
mrivera-ms merged 4 commits intomainfrom
southworks/fix/eslint/botbuilder-dialogs-adaptive/recognizers

Conversation

@sw-joelmut
Copy link
Collaborator

Adresses #2745
#minor

Description

When reviewing the botbuilder-js project, it was found that eslint is showing several warnings for the botbuilder-dialogs-adaptive library.

Specific Changes

  • Replaced strings quotes with the correct one depending on the case
  • Replaced hasOwnProperty with Object.prototype.hasOwnProperty.call
  • Adjusted formatting
  • Limited importing scopes
  • Added missing jsdocs documentation for parameters and returns for functions
  • Removed unused variables

Testing

Eslint with no warnings and tests passed
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner January 20, 2022 19:46
@coveralls
Copy link

coveralls commented Jan 20, 2022

Pull Request Test Coverage Report for Build 1775488402

  • 6 of 6 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 84.546%

Totals Coverage Status
Change from base Build 1775406937: -0.04%
Covered Lines: 19669
Relevant Lines: 22037

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 4a11f5d into main Feb 1, 2022
@mrivera-ms mrivera-ms deleted the southworks/fix/eslint/botbuilder-dialogs-adaptive/recognizers branch February 1, 2022 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants