Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

port: [#4062] Log BadRequest in adapter (#6135)#4155

Merged
mrivera-ms merged 1 commit intomainfrom
southworks/update/port-add-logger-to-bad-request
Mar 11, 2022
Merged

port: [#4062] Log BadRequest in adapter (#6135)#4155
mrivera-ms merged 1 commit intomainfrom
southworks/update/port-add-logger-to-bad-request

Conversation

@ceciliaavila
Copy link
Collaborator

Fixes #4062

Description

This PR ports the changes in BotBuilder-DotNet's PR#6135 adding a warn logger in CloudAdapter's process method when the activity hasn't a type.

Specific Changes

  • Updated CloudAdapter class adding a console.warn when a BadRequest error is thrown for a missing activity type.

Testing

This image shows the tests passing after the change.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner March 11, 2022 18:13
@coveralls
Copy link

coveralls commented Mar 11, 2022

Pull Request Test Coverage Report for Build 1970319030

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 84.544%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/cloudAdapter.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/cloudAdapter.ts 1 32.54%
Totals Coverage Status
Change from base Build 1955117631: -0.2%
Covered Lines: 19669
Relevant Lines: 22038

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit afbc0c1 into main Mar 11, 2022
@mrivera-ms mrivera-ms deleted the southworks/update/port-add-logger-to-bad-request branch March 11, 2022 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

port: Log BadRequest in adapter (#6135)

3 participants