Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

chore: [#3518] Remove public access modifier from botbuilder-lg#4219

Merged
tracyboehrer merged 2 commits intomainfrom
southworks/delete/public-botbuilder-lg
Jun 15, 2022
Merged

chore: [#3518] Remove public access modifier from botbuilder-lg#4219
tracyboehrer merged 2 commits intomainfrom
southworks/delete/public-botbuilder-lg

Conversation

@sw-joelmut
Copy link
Collaborator

Addresses #3518
#minor

Description

This PR removes the public access modifier from all constructors, methods and properties for the botbuilder-lg folder.

Note: These changes do not include the Typescript Constructor Shorthands (link).

Specific Changes

  • Removes all public access modifiers from where it's declared under the botbuilder-lg folder.

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 2, 2022 14:19
@coveralls
Copy link

coveralls commented May 2, 2022

Pull Request Test Coverage Report for Build 2258454323

  • 58 of 59 (98.31%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.48%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-lg/src/analyzerOptions.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 2245574340: -0.003%
Covered Lines: 19902
Relevant Lines: 22310

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 36ed9a0 into main Jun 15, 2022
@tracyboehrer tracyboehrer deleted the southworks/delete/public-botbuilder-lg branch June 15, 2022 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants