fix: [#4204] Fix remaining eslint warnings - botbuilder-dialogs (2/2)

[ceciliaavila]

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-dialogs library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separate task as they require deeper analysis and testing.

Specific Changes

• Applied auto-fixes with yarn lint --fix
  • Add trailing commas.
  • Fix spacing.
  • Fix indentation.
  • Add blank line in between comments.
  • Fix quoting.
  • Replace arrow functions: () => with function ().
  • Replace let with const.
• Applied manual fixes for:
  • Missing documentation.
  • Unused parameters and imports.
  • Replacing hasOwnProperty calls.
  • Fixing lodash imports.
• Updated methods documentation in botbuilder-dialogs.api.md.

Testing

Here we can see the eslint status before and after.

[coveralls]

Pull Request Test Coverage Report for Build 2656834622

• 7 of 8 (87.5%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.003%) to 84.479%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/botbuilder-dialogs/src/dialogSet.ts	3	4	75.0%

Totals
Change from base Build 2656737347:	-0.003%
Covered Lines:	19904
Relevant Lines:	22312

---

💛 - Coveralls