This repository was archived by the owner on Jan 5, 2026. It is now read-only.
fix: [#4325] Skip Storage properties from BotState class#4326
Merged
tracyboehrer merged 4 commits intomainfrom Sep 19, 2022
Merged
fix: [#4325] Skip Storage properties from BotState class#4326tracyboehrer merged 4 commits intomainfrom
tracyboehrer merged 4 commits intomainfrom
Conversation
Pull Request Test Coverage Report for Build 3082687836
💛 - Coveralls |
tracyboehrer
approved these changes
Sep 19, 2022
tracyboehrer
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Add skip storage properties functionality to BotState * Add unit tests for BotState skipProperties * Fix test:compat * test for linux # Conflicts: # libraries/botbuilder-dialogs-adaptive-testing/tests/action.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4325
Description
This PR fixes an issue where the Host calls a Skill using the
BeginSkillaction, and right after ending the conversation with the skill aTextInputis prompt.Moreover, after the input was prompted and provided the text response, the Host fails, because it tries to call the Skill again.
Furthermore, the Host was trying to call the Skill because the
ConversationStatewas being updated with old information due to theBeginSkillclass was saving into the Storage theConversationIdFactoryandConversationStateinstances (that also have aStorage).By skipping the two properties, like DotNet does, solved the issue.
Specific Changes
BotStateclass, iterating the state object properties to find and skip the desired properties from outside theBotStatescope, to then compare them in the hash functionality.BeginSkill.beginDialogmethod.BotStateandBeginSkillchanges.Testing
The following image shows the comparison between the DotNet's Storage saved information and the one used in JavaScript.
