Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

fix: [#4324] Explicit error logging inside jwtTokenExtractor in botframework-connector#4333

Merged
tracyboehrer merged 1 commit intomainfrom
southworks/fix/remove-console-error
Oct 18, 2022
Merged

fix: [#4324] Explicit error logging inside jwtTokenExtractor in botframework-connector#4333
tracyboehrer merged 1 commit intomainfrom
southworks/fix/remove-console-error

Conversation

@ceciliaavila
Copy link
Collaborator

Fixes #4324

Description

This PR removes the unnecessary console.error statement in the jwtTokenExtractor class.

Specific Changes

  • Deleted console.error statement in the jwtTokenExtractor class. The try-catch block was no longer necessary either.

Testing

Here we can see the unit tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner October 11, 2022 15:43
@coveralls
Copy link

coveralls commented Oct 11, 2022

Pull Request Test Coverage Report for Build 3228265977

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 84.615%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 3206725406: 0.002%
Covered Lines: 19922
Relevant Lines: 22305

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit e997b23 into main Oct 18, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/remove-console-error branch October 18, 2022 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicit error logging inside jwtTokenExtractor in botframework-connector

3 participants