This repository was archived by the owner on Jan 5, 2026. It is now read-only.
fix: [#4324] Explicit error logging inside jwtTokenExtractor in botframework-connector#4333
Merged
tracyboehrer merged 1 commit intomainfrom Oct 18, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 3228265977
💛 - Coveralls |
tracyboehrer
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4324
Description
This PR removes the unnecessary
console.errorstatement in the jwtTokenExtractor class.Specific Changes
console.errorstatement in the jwtTokenExtractor class. The try-catch block was no longer necessary either.Testing
Here we can see the unit tests passing after the changes.
