Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

port: [#6432] TeamsInfo.GetMemberAsync(...) doesn't work properly in Skill Bot scenario, it returns http 405 error (#6443)#4344

Merged
tracyboehrer merged 3 commits intomainfrom
southworks/update/implement-teams-get-member-skills
Oct 18, 2022
Merged

port: [#6432] TeamsInfo.GetMemberAsync(...) doesn't work properly in Skill Bot scenario, it returns http 405 error (#6443)#4344
tracyboehrer merged 3 commits intomainfrom
southworks/update/implement-teams-get-member-skills

Conversation

@ceciliaavila
Copy link
Collaborator

Fixes #4317

Description

This PR ports the changes in PR#6443 to fix the error thrown when executing the TeamsInfo.GetMember in a root-skill scenario.

Specific Changes

  • Added the handleGetConversationMember and onGetConversationMember methods in ChannelServiceHandlerBase.
  • Added the processGetConversationMember method in channelServiceRoutes.
  • Added the onGetConversationMember method in the CloudSkillHandler class.
  • Added the implementation of the onGetMember method in the SkillHandlerImpl class.
  • Added the cloudSkillHandler.test.js file with unit test for CloudSkillHandler constructor and onGetConversationMember methods.

Testing

These images show the skill bot retrieving the member's information successfully and the new unit test passing.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner October 17, 2022 13:35
@coveralls
Copy link

coveralls commented Oct 17, 2022

Pull Request Test Coverage Report for Build 3265595790

  • 2 of 18 (11.11%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 84.61%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/channelServiceHandlerBase.ts 0 3 0.0%
libraries/botbuilder/src/skills/skillHandlerImpl.ts 0 6 0.0%
libraries/botbuilder/src/channelServiceRoutes.ts 1 8 12.5%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 3206725406: -0.004%
Covered Lines: 19936
Relevant Lines: 22326

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit dcadf49 into main Oct 18, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/implement-teams-get-member-skills branch October 18, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

port: [#6432] TeamsInfo.GetMemberAsync(...) doesn't work properly in Skill Bot scenario, it returns http 405 error (#6443)

3 participants