This repository was archived by the owner on Jan 5, 2026. It is now read-only.
port: [#6432] TeamsInfo.GetMemberAsync(...) doesn't work properly in Skill Bot scenario, it returns http 405 error (#6443)#4344
Merged
tracyboehrer merged 3 commits intomainfrom Oct 18, 2022
Conversation
Pull Request Test Coverage Report for Build 3265595790
💛 - Coveralls |
tracyboehrer
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4317
Description
This PR ports the changes in PR#6443 to fix the error thrown when executing the TeamsInfo.GetMember in a root-skill scenario.
Specific Changes
ChannelServiceHandlerBase.channelServiceRoutes.CloudSkillHandlerclass.SkillHandlerImplclass.cloudSkillHandler.test.jsfile with unit test for CloudSkillHandler constructor and onGetConversationMember methods.Testing
These images show the skill bot retrieving the member's information successfully and the new unit test passing.
