[#631][PORT] [Slack Adapters] Add Slack Functional Test #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/southworks/botbuilder-python into southworks/fix/slack-adapter-functional-test
tracyboehrer
approved these changes
Feb 1, 2021
Member
|
@denscollo Apologies for the delay in review. If someone can please merge changes from main, we can verify the PR validation works before merging and closing. |
Collaborator
Done @tracyboehrer. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631
Description
This PR ports the Slack adapter functional test from PR# 3108 from botbuilder-dotnet.
Specific Changes
test_slack_client.pyrequirements.txtin the functional-tests libraryNote: SlackHistoryRetrieve port was not required, in DotNet it is used by JsonDeserealize to get the response message, but in Python, the implementation differs.
Testing
The following images showcase the pipeline running the test successfully and how it looks on the bot through Slack:
