fix type annotation #1459
Closed
fix type annotation #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSCode's pylance complained about this, the message was: ``` List expression not allowed in type annotation Use List[T] instead ``` It'd be a good idea to scan all the code for other occurrences of the issue.
tracyboehrer
approved these changes
Jan 5, 2021
tracyboehrer
requested changes
Jan 5, 2021
Member
tracyboehrer
left a comment
tracyboehrer
left a comment
There was a problem hiding this comment.
This does produce an error during build:
libraries/botbuilder-ai/botbuilder/ai/qna/utils/qna_card_builder.py:17: in QnACardBuilder
suggestions: List[str], card_title: str, card_no_match: str
E NameError: name 'List' is not defined
|
@tracyboehrer Can we get some traction on this PR from the customer. |
Member
|
Replaced by #1491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1458 but only for a single file. It'd be a good idea to scan all the code for other occurrences of the issue.
Description
VSCode's pylance complained about this, the message was:
Specific Changes
[str]toList[str]in the type annotation ofget_suggestions_card()