This repository was archived by the owner on Jan 15, 2025. It is now read-only.
bf luis:build support to republish luis app if users specify a new publishing mode #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
approved these changes
Mar 12, 2021
Contributor
Author
|
@munozemilio could you help to approve this. Composer need this fix to unblock their directVersionPublish feature. |
munozemilio
approved these changes
Mar 17, 2021
Contributor
munozemilio
left a comment
munozemilio
left a comment
There was a problem hiding this comment.
CIL for a possible simplification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1143. The main fix is to support republishing luis app if users specify a new publishing mode, e.g. users have first published a luis app with directionVersionPublish mode, now they can also publish the same lu content to other modes like Production slot or Staging slot. Before the fix, the republishing logic is completely controlled by content comparisons between current lu content and existing luis portal lu content which means users have no ways to republish to other modes if their lu contents have no changes.