Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Mar 11, 2020

QnA build CLI implementation for https://github.com/microsoft/botframework-cli/blob/master/specs/qnamaker-build.md.

To test, go to packages/qnamaker/bin folder and run below command:
run qnamaker:build --in ../test/fixtures/testcases/qnabuild/sandwich/qnafiles/sandwich.en-us.qna --subscriptionKey xxx --botName xxx --dialog --log

Update 4.7:
Multiturn is supported now. Multiturn with references is also supported. Corresponding tests are also added.

@vishwacsena @boydc2014, you can have a try to see if there are any issues.

@feich-ms feich-ms changed the title qna build qnamaker build CLI Mar 11, 2020
@feich-ms feich-ms marked this pull request as ready for review March 25, 2020 08:25
@feich-ms feich-ms requested review from Danieladu and boydc2014 March 25, 2020 09:35
@vishwacsena vishwacsena self-assigned this Mar 27, 2020
Copy link
Contributor

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIL

@feich-ms
Copy link
Contributor Author

@vishwacsena, I have reverted the file and url reference related logic in lu build core functionality. Meanwhile, I exposed two new functions naming importFileReference and importUrlReference. They import url or file reference into kb and return the extracted kb pairs with qna format. You can refer the qnabuild.test.js to see how to call them. Of course, they can be adjusted based on composer requirements in the future.

@vishwacsena
Copy link
Contributor

@feich-ms this is looking good. I pushed up minor changes via this commit

@vishwacsena
Copy link
Contributor

@munozemilio can you take a look and review the updates based on your PR feedback? Thanks!

@feich-ms
Copy link
Contributor Author

feich-ms commented Apr 24, 2020

@vishwacsena, I have updated the code/tests/docs per our discussion. All the qna files with same locale(default to en-us) will be merged into one and then published. The kb name will be botName(suffix).locale.qna. The dialog assets will also be named with botName.locale.qna.dialog(Recognizer) or botName.qna.dialog(MultiRecognizer). Please verify. If no other issues, we can merge this one.

@vishwacsena vishwacsena merged commit 7a3cc7d into master Apr 25, 2020
@vishwacsena vishwacsena deleted the feich/qnabuild branch April 25, 2020 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

R9 Release 9 - May 15th, 2020

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants