Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Conversation

@vishwacsena
Copy link
Contributor

Tien discovered this issue.Simple fix to get both the JSON -> QnA as well as QnA -> JSON be consistent in the order information should appear in .qna format.

@vishwacsena
Copy link
Contributor Author

@vipeketi can you please take a look at this change as well? This bears an impact on the import format to QnA maker in that the ID will now appear after the source. Need update to the download as well as need to ensure replace API supports it as well.

@vishwacsena vishwacsena requested a review from vipeketi April 14, 2020 21:45
@vishwacsena
Copy link
Contributor Author

@vipeketi can you comment if you can take this change on the QnA service side as well?

@vipeketi
Copy link

@vipeketi can you comment if you can take this change on the QnA service side as well?

@vishwacsena I have made changes for our implementation as below. Hope it works.
// Definition bug fixed for swapping IdMark and SourceInfo Order
qnaDefinition
: qnaIdMark? qnaSourceInfo? qnaQuestion moreQuestionsBody qnaAnswerBody promptSection?
;

@vishwacsena vishwacsena added the R9 Release 9 - May 15th, 2020 label Apr 23, 2020
@vishwacsena vishwacsena merged commit b77505d into master Apr 24, 2020
@vishwacsena vishwacsena deleted the vishwac/qnafix branch April 24, 2020 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

R9 Release 9 - May 15th, 2020

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants