Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Apr 16, 2020

fix issue #713 from composer. Main changes are supporting multi trigger intents mapping to same lu file in config and logic. Also added tests to cover the scenario. Considering such cases,

triggerIntentA -> a.lu
triggerIntentB -> a.lu
triggerIntentC -> b.lu

After cross train, interruption intent in a.lu will only include utterances under triggerIntentC.

Copy link
Contributor

@boydc2014 boydc2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this also work in cli

@feich-ms
Copy link
Contributor Author

@boydc2014 fixed:

  1. align the config format between cli and core library.
  2. adjust the test cases.
  3. adjust cli branch https://github.com/microsoft/botframework-cli/tree/cross-train based on the new changes.

@feich-ms feich-ms merged commit cb9d291 into master Apr 20, 2020
@munozemilio munozemilio deleted the feich/fixMultiTriggersToSingleLuFile branch May 5, 2020 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants