-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Closed
Closed
Copy link
Labels
Area: EngineeringInternal issues that are related to improving code quality, refactorings, code cleanup, etc.Internal issues that are related to improving code quality, refactorings, code cleanup, etc.P2Nice to haveNice to have
Description
Several classes in dotnet and the JS repos were previously autogenerated from . We moved away from autogenerating these classes from the swagger file and we are now maintaining them by hand.
The AutoGen comment at the top of the classes is erroneous and confusing for the the new developer.
This PR involves:
- Removing the autogen comment from the top of the files (and add the standard copyright to them).
- Update classes to make them easier to maintain.
In dotnet:
- Remove the partial declaration for the classes and merge in any *Ex classes.
- Merge any other helper methods into the class (like ToAttachment for example).
In JS:
- Remove autogen comment
- All these classes are in index.ts, do we break them in separate files to make them easier to maintain parity across repos?
In Python
- Remove autogen comment
- All these classes are in _models.py, do we break them in separate files to make them easier to maintain parity across repos?
Tracking Status
Dotnet SDK (Tracked in TBD)
- PR
- Merged
Javascript SDK (Tracked in TBD)
- PR
- Merged
Python SDK (Tracked in TBD)
- PR
- Merged
Metadata
Metadata
Assignees
Labels
Area: EngineeringInternal issues that are related to improving code quality, refactorings, code cleanup, etc.Internal issues that are related to improving code quality, refactorings, code cleanup, etc.P2Nice to haveNice to have