Skip to content

Conversation

@jmendiara
Copy link
Contributor

IDialogResult<T> interface has a template syntax, so endDialogWithResult which takes that interface as argument, should propagate the template

@azurecla
Copy link

azurecla commented Oct 7, 2016

Hi @jmendiara, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@jmendiara jmendiara changed the title Propagate types in the Definition Propagate types in endDialogWithResult Oct 7, 2016
@jmendiara jmendiara changed the title Propagate types in endDialogWithResult [Node] Propagate types in endDialogWithResult Oct 7, 2016
@Stevenic
Copy link
Contributor

So that's not actually going to achieve anything. Can you show me an example where that would matter?

@jmendiara
Copy link
Contributor Author

Yeah, you are right. This does not matter at all in userland. I was just looking for consistency within your definitions

https://github.com/Microsoft/BotBuilder/blob/master/Node/core/src/botbuilder.d.ts#L1133

beginDialog<T>(id: string, args?: T): Session;

https://github.com/Microsoft/BotBuilder/blob/master/Node/core/src/botbuilder.d.ts#L1141

 replaceDialog<T>(id: string, args?: T): Session;

@Stevenic
Copy link
Contributor

Fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants