Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@lauren-mills
Copy link
Contributor

@lauren-mills lauren-mills commented Jul 12, 2019

Purpose

What is the context of this pull request? Why is it being done?
Pull changes from #1843

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

Tests

Is this covered by existing tests or new ones? If no, why not?

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.*

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@pr-triage pr-triage bot added the PR: draft label Jul 12, 2019
@lauren-mills lauren-mills marked this pull request as ready for review July 15, 2019 16:27
@lauren-mills lauren-mills self-assigned this Jul 15, 2019
@darrenj darrenj merged commit 58da49f into master Jul 16, 2019
@darrenj darrenj deleted the lamil/skill_deployment branch July 16, 2019 08:44
@pr-triage pr-triage bot added the merged label Jul 16, 2019
lzc850612 pushed a commit that referenced this pull request Jul 31, 2019
* skill sample deployment updates

* skill template deployment updates

* added useluisgen flag to update script (build pipeline)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants