Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Conversation

@xieofxie
Copy link
Contributor

Purpose

What is the context of this pull request? Why is it being done?

Close #1960

Changes

Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)

Return no route for BadRequest. This behavior (return 400 for not covered areas) is not guaranteed stable in azure map.

Tests

Is this covered by existing tests or new ones? If no, why not?

user: find a coffee shop in tokyo
user: [input current(tokyo) and select coffee shop]
bot: It seems like something went wrong. (before)
bot: Sorry, I didn't find any route. (now)

Feature Plan

Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.

Checklist

General

  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the appropriate tests
  • I have updated related documentation

Bots

  • I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
  • I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

  • I have replicated my changes in the Virtual Assistant Template and Sample projects
  • I have replicated my changes in the Skill Template and Sample projects

@ryanisgrig
Copy link
Collaborator

Can you make this PR against the next branch?

@darrenj darrenj changed the base branch from master to next July 31, 2019 18:35
@xieofxie
Copy link
Contributor Author

xieofxie commented Aug 1, 2019

OK, changed

@ryanisgrig ryanisgrig merged commit 6dae291 into microsoft:next Aug 1, 2019
@xieofxie xieofxie deleted the noroute branch August 2, 2019 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants