-
Notifications
You must be signed in to change notification settings - Fork 5
Integration tests & updated docs #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add pytest configuration and test fixtures - Add tests for blueprint parser, DSE execution, and plugin system - Add fixture plugins for testing kernels, steps, and transforms - Add test utilities and helper functions - Bug fix tree depth calculation to include root
- Add docs for dataflow modeling, hardware kernels, plugin registry - Rename execution_tree_dse.md to design_space_exploration.md - Delete plugin_library.md (replaced by plugin_registry.md) - Add BERT example README and quicktest yaml - Add plugin error handling tests - Update parser with help text and schema generation
- Simplify Brainsmith Library section to reference plugin registry - Add concrete transform example with SetPumpedCompute - Add base_finn_config fixture for testing - Add inheritance blueprint helpers for parent/grandparent testing - Add ExpectedExecutionLevel dataclass for tree validation
… diagram - Add comprehensive examples for all 5 kernel components - Include kernel creation workflow diagram - Add pre-release notes about ongoing standardization - Link to documentation from main README
Collaborator
Author
|
Troubleshooting some issues with the BERT example after my changes, but documentation and basic integration test suite are ready for review. Both are far from comprehensive, but a good start to empower our collaborators. |
…rser inheritance - Fix recursive inheritance handling in blueprint parser for multi-level extends - Update bert_quicktest.yaml to extend bert_demo.yaml instead of bert.yaml - Enable split_large_fifos in bert_demo.yaml FINN config - Disable pre-calc folding for quicktest to circumvent bug - Remove quicktest_folding.json testing artifact
jsmonson
reviewed
Sep 22, 2025
jsmonson
reviewed
Sep 22, 2025
jsmonson
reviewed
Sep 22, 2025
jsmonson
reviewed
Sep 22, 2025
jsmonson
reviewed
Sep 22, 2025
jsmonson
approved these changes
Sep 22, 2025
Contributor
jsmonson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! PLease see my comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add core integration test suite and documentation improvements
Summary
Core Changes
Bug Fixes & API Improvements
BlueprintParserclass to standaloneparse_blueprint()functionfind()andall()methodsTesting Infrastructure
Documentation
BERT Example Improvements
bert_quicktest.yamlfor rapid testing (single layer, minimal folding)