Skip to content

Add Automation Names to the GraphNumPad#1145

Merged
grochocki merged 5 commits into
microsoft:masterfrom
sanderl:GraphNumPadAcc
Apr 14, 2020
Merged

Add Automation Names to the GraphNumPad#1145
grochocki merged 5 commits into
microsoft:masterfrom
sanderl:GraphNumPadAcc

Conversation

@sanderl
Copy link
Copy Markdown
Contributor

@sanderl sanderl commented Apr 2, 2020

Fixes #1127, Fixes #1129.

Description of the changes:

  • Adds automation names to all of the buttons in the GraphNumPad
  • Disables KeyboardShortCuts when entering graphing mode

How changes were validated:

  • manually testing the shortcuts are active on non-graphing modes
  • manually using accessibility insights

@sanderl sanderl added the graphing calculator Work items related to the graphing calculator feature. label Apr 2, 2020
@sanderl sanderl requested a review from joseartrivera April 2, 2020 17:23
Comment thread src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml Outdated
Comment thread src/Calculator/Views/MainPage.xaml.cpp Outdated
Comment thread src/Calculator/Views/MainPage.xaml.cpp
@grochocki grochocki merged commit 7612b69 into microsoft:master Apr 14, 2020
@sanderl sanderl deleted the GraphNumPadAcc branch May 26, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphing calculator Work items related to the graphing calculator feature.

Projects

None yet

3 participants