Skip to content

Update Icons Implement the Graph View Button#1149

Merged
grochocki merged 7 commits into
microsoft:masterfrom
sanderl:IconUpdate
Apr 14, 2020
Merged

Update Icons Implement the Graph View Button#1149
grochocki merged 7 commits into
microsoft:masterfrom
sanderl:IconUpdate

Conversation

@sanderl
Copy link
Copy Markdown
Contributor

@sanderl sanderl commented Apr 3, 2020

Fixes #1070, Fixes #995.

Description of the changes:

  • Updated the icon font and updated the function analysis and negate icons
  • Changed the zoom reset button to graph view with automatic best fit and manual adjustment
  • Fixed bug where the window ranges in graph settings didn't update after panning or zooming

How changes were validated:

  • manual

@sanderl sanderl added the graphing calculator Work items related to the graphing calculator feature. label Apr 3, 2020
@sanderl sanderl requested a review from joseartrivera April 3, 2020 15:28
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.h Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.h Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.h Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Outdated
Comment thread src/GraphControl/Control/Grapher.cpp Outdated
@sanderl sanderl requested a review from joseartrivera April 7, 2020 23:06
Comment thread src/GraphControl/Control/Grapher.cpp Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml
Comment thread src/GraphControl/Control/Grapher.cpp Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml
}
else
{
GraphingControl->ResetGrid();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if related to this PR, but it doesn't seem like ResetGrid is always going back to the original perfect auto fit after it was initially moved.

…hsettings now update IsManualAdjustment when changed
@grochocki grochocki merged commit 3a8fcaa into microsoft:master Apr 14, 2020
@sanderl sanderl deleted the IconUpdate branch May 26, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphing calculator Work items related to the graphing calculator feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop moving graph when adding new equation Refresh select graphing mode iconography

3 participants