Fix bug preventing the app to launch from the start menu when compiled in debug#1162
Merged
Conversation
joseartrivera
approved these changes
Apr 10, 2020
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the
Assertat launch when debugging with VS.Reason
The lock in
LocalizationService::GetInstancewas blocking the launch of the app because called too early during the initialization of the app.This call was made by the static map
GraphingNumPad:buttonOutputinitialized during the launch, even when Graphing Calculator wasn't the selected mode.Description of the changes:
Impact
It should improve the performance of the application launch.
How changes were validated: