Fix Settings page text not adopting High Contrast Aquatic/Desert themes#2463
Merged
Conversation
Add HighContrast theme dictionary to Settings.xaml that overrides TextFillColorPrimaryBrush and TextFillColorSecondaryBrush to use SystemColorWindowTextColor. Also fix SettingsRichTextBlockStyle using TextFillColorPrimary (a Color) instead of TextFillColorPrimaryBrush (a Brush) for the Foreground property. Fixes AB#40625114 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Settings page text colors not updating correctly when Windows High Contrast themes (e.g., Aquatic/Desert) are enabled, by adding HighContrast theme-specific resource overrides and correcting an incorrect RichTextBlock foreground resource type.
Changes:
- Added a
HighContrastThemeDictionary inSettings.xamloverridingTextFillColorPrimaryBrush/TextFillColorSecondaryBrushto useSystemColorWindowTextColor. - Fixed
SettingsRichTextBlockStyleto useTextFillColorPrimaryBrush(Brush) instead ofTextFillColorPrimary(Color) forForeground.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arcadiogarcia
approved these changes
May 19, 2026
edwcry
approved these changes
May 20, 2026
karska-test
approved these changes
May 20, 2026
tian-lt
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Text are not adopting the high contrast aquatic and desert mode in settings page.
Description of the changes
Add HighContrast theme dictionary to Settings.xaml that overrides TextFillColorPrimaryBrush and TextFillColorSecondaryBrush to use SystemColorWindowTextColor. Also fix SettingsRichTextBlockStyle using TextFillColorPrimary (a Color) instead of TextFillColorPrimaryBrush (a Brush) for the Foreground property.
How changes were validated
Manual testing with accessibility themes
Before
After
