Skip to content

CalculationResult: keep focus on Scroll buttons#669

Merged
sanderl merged 1 commit into
microsoft:masterfrom
rudyhuyn:CalculationResultScrollButtonFocus
Apr 8, 2020
Merged

CalculationResult: keep focus on Scroll buttons#669
sanderl merged 1 commit into
microsoft:masterfrom
rudyhuyn:CalculationResultScrollButtonFocus

Conversation

@rudyhuyn
Copy link
Copy Markdown
Collaborator

Fixes #651

Description of the changes:

  • Modify CalculationResult::UpdateScrollButtons to switch the focus from ScrollLeft to ScrollRight when one of them is focused but will be collapsed.

How changes were validated:

  • manually

How to test it

  • Reduce window size to the minimum
  • Switch to Programmer mode
  • Select BIN
  • Type 1111111111...1111111

@rudyhuyn
Copy link
Copy Markdown
Collaborator Author

rebased!

@rudyhuyn rudyhuyn reopened this Sep 28, 2019
Copy link
Copy Markdown
Contributor

@sanderl sanderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a buddy build and buddy test of this change. It is working nicely. Thanks for the update.

@sanderl sanderl merged commit a6ac3bb into microsoft:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CalculationResult should keep the focus on scroll buttons when their visibility changes

3 participants