Skip to content

refactor HistoryTest.cpp to test the history using HistoryViewModel#784

Merged
sanderl merged 3 commits into
microsoft:masterfrom
rudyhuyn:Fix783
Apr 8, 2020
Merged

refactor HistoryTest.cpp to test the history using HistoryViewModel#784
sanderl merged 3 commits into
microsoft:masterfrom
rudyhuyn:Fix783

Conversation

@rudyhuyn
Copy link
Copy Markdown
Collaborator

@rudyhuyn rudyhuyn commented Nov 7, 2019

Fixes #783

Description of the changes:

  • Modify HistoryTest.cpp to use HistoryViewModel instead of CalculatorHistory. in order to test the full stack and not only the CalcManager part.
    • ⚠ one of the big difference is how the history items collection is ordered.

Also:

  • Expose some methods from CalcManager (a native library) via StandardCalcViewModel, making them accessible from another windows runtime library.
  • make PropertyNames public instead of internal so other (dynamic) libraries can use them.
  • move Utils::GetStringValue from CalcViewModel to CalculatorUnitTests

How changes were validated:

  • Manually

@HowardWolosky HowardWolosky added the codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) label Nov 11, 2019
Copy link
Copy Markdown
Contributor

@sanderl sanderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes needed that I saw. It looks like there are merge conflicts. Once the merge conflicts are fixed, I'll buddy build and buddy test.

Comment thread src/CalculatorUnitTests/HistoryTests.cpp
Comment thread src/CalculatorUnitTests/HistoryTests.cpp Outdated
@ghost ghost added the no recent activity label Dec 3, 2019
@ghost
Copy link
Copy Markdown

ghost commented Dec 3, 2019

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. Thank you for your contributions to Windows Calculator!

@rudyhuyn
Copy link
Copy Markdown
Collaborator Author

rudyhuyn commented Apr 2, 2020

!rebased

@sanderl sanderl merged commit 825b42a into microsoft:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) fixing approved issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor HistoryTest.cpp to use HistoryViewModel (from CalcViewModel) instead of CalculatorHistory (from CalcManager)

4 participants