Add overloads to the GetValue() methods of ClrField classes that allo… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w the caller to specify if String fields should be returned as System.String objects (current behavior) or the address of the String object should be returned instead.
leculver
added a commit
that referenced
this pull request
Sep 21, 2015
Add overloads to the GetValue() methods of ClrField classes that allo…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetValue() methods of ClrInstanceField, ClrStaticField and ClrThreadStaticField all convert string fields into a System.String value.
However it is often useful to want just the address of the String object, instead of getting the actual string contents. You can work around this currently by calling GetAddress() instead and then reading a pointer-sized value at that address, but it is inconvenient.
This patch adds an overload to all the GetValue() methods that allow you to control if String fields should be returned as the string contents or as the address of the underlying String object.