This repository was archived by the owner on May 20, 2025. It is now read-only.
[CLI] Fix sourcemap output filename #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/script/command-executor.ts
Outdated
|
|
||
| if (command.outputDir) { | ||
| command.sourcemapOutput = path.join(command.outputDir, bundleName + ".map"); | ||
| if (command.sourcemapOutput) { |
Contributor
There was a problem hiding this comment.
Can we check if the sourcemapOutput already ends with .map? In that case we don't need adding it manually.
Contributor
Author
There was a problem hiding this comment.
Thank you for pointing that out! I've updated it.
DmitriyKirakosyan
approved these changes
Nov 20, 2024
lucen-ms
approved these changes
Nov 29, 2024
Contributor
|
Due to the PR merge, the location of the build output used in the existing appcenter has changed. Wouldn't it be better to modify these outputs in a personal repository? |
Contributor
|
@ukcasso Thank you for your feedback! This PR addresses an issue with incorrect behavior, so we believe it’s important to merge it into the public repository to ensure consistency and accuracy for everyone. We appreciate your understanding! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sourcemapOutput Overwrite
There's an issue where the sourcemap output is overwritten when both the sourcemap output and output directory are used together in the CLI.