Fix malformed shell function aliases in artifacts-helper#111
Merged
Conversation
Closed
…_BLOCK in bash -c string Agent-Logs-Url: https://github.com/microsoft/codespace-features/sessions/5148a449-0bbd-4e16-b7b4-a4629bee57c0 Co-authored-by: markphip <933108+markphip@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/codespace-features/sessions/5148a449-0bbd-4e16-b7b4-a4629bee57c0 Co-authored-by: markphip <933108+markphip@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix malformed alias definitions in artifacts-helper
Fix malformed shell function aliases in artifacts-helper
Apr 27, 2026
markphip
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing as a non-root user, the shell function shims written to rc files were missing path quoting and argument forwarding, producing
dotnet() { /usr/local/share/codespace-shims/dotnet ; }instead ofdotnet() { "/usr/local/share/codespace-shims/dotnet" "$@"; }.Root cause
The
ALIASES_BLOCKstring contains literal"characters. Embedding it insidebash -c "..."caused the outer shell to misparse the quotes during expansion:The inner bash received a mangled command where the path quotes and
"$@"were consumed as shell syntax rather than literal characters.Changes
install.sh: WriteALIASES_BLOCKto a temp file first, then append viacat— eliminating the quoting hazard entirely. Also quotes${_REMOTE_USER}to prevent word splitting.test_shim_integration.sh: Added checks that alias definitions in rc files include properly quoted paths and"$@"argument forwarding.devcontainer-feature.json: Bumped version to3.0.8.