Additional EH tests #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding some more selected EH tests. At this point I'm still not including particular tests that were repros for MSVC compiler bugs since more work is needed to tell if these are useful.
Member
Author
|
@majnemer - PTAL |
eh/ehthrow.cxx
Outdated
There was a problem hiding this comment.
This will not compile with clang, can you make the return type int?
|
Looks good, found some trivial issues. |
Change main() returns to 'int' and modify a passed parameter reference to const.
Member
Author
|
@majnemer made the changes you suggested. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some more selected EH tests. At this point I'm still not including
particular tests that were repros for MSVC compiler bugs since more work is
needed to tell if these are useful.