Allow opt-in go cli scanning #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
tevoinea
commented
Dec 17, 2021
| "preLaunchTask": "build", | ||
| // If you have changed target frameworks, make sure to update the program path. | ||
| "program": "${workspaceFolder}/src/Microsoft.ComponentDetection/bin/Debug/net6.0/Microsoft.ComponentDetection.dll", | ||
| "program": "${workspaceFolder}/src/Microsoft.ComponentDetection/bin/Debug/netcoreapp3.1/Microsoft.ComponentDetection.dll", |
Member
Author
There was a problem hiding this comment.
Tiny thing we missed moving back to netcore 3.1
JamieMagee
reviewed
Dec 17, 2021
Comment on lines
+61
to
+64
| catch | ||
| { | ||
| Logger.LogInfo("Failed to detect components using go cli."); | ||
| } |
Member
There was a problem hiding this comment.
Can you log the exception here
JamieMagee
reviewed
Dec 17, 2021
|
|
||
| private bool IsGoCliManuallyEnabled() | ||
| { | ||
| return EnvVarService.DoesEnvironmentVariableExist("EnableGoCliScan"); |
Member
There was a problem hiding this comment.
Can you create a constants class for environment variables? If we're going to create a lot of these, it'll be easier to keep track of.
JamieMagee
approved these changes
Dec 17, 2021
Member
JamieMagee
left a comment
JamieMagee
left a comment
There was a problem hiding this comment.
Couple of small things, but nothing blocking.
JamieMagee
added
type:ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using go cli to scan is more accurate than parsing go.sum files, but go projects aren't always restored in a workflow. This results in go restoring packages in a workflow where it's not required. By allowing an opt-in we give users the power to make the right choice for their specific situations.
We still fall back to manual parsing if go cli fails.