Fix Docker image ID test for Docker 29#1633
Merged
JamieMagee merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1633 +/- ##
=====================================
Coverage 90.7% 90.7%
=====================================
Files 444 444
Lines 39709 39710 +1
Branches 2418 2418
=====================================
+ Hits 36029 36031 +2
Misses 3187 3187
+ Partials 493 492 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grvillic
approved these changes
Feb 18, 2026
Member
Author
|
Verification test failures are expected. We are comparing the output from Docker 29, with the old, cached, output from an earlier version of Docker. The verification test output will be updated and cached with Docker 29 after merge to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions runners were updated to Docker 29.1.x on February 9. Docker 29 makes the containerd image store the default for fresh installs, which changes how image IDs are reported.
With the legacy graphdriver,
docker inspectreturned the config digest as the image ID. With the containerd image store, it returns the manifest digest instead. The test image hasn't changed -- both digests are valid for it -- butDockerService_PopulatesBaseImageAndLayerDetailsAsyncwas hardcoded to expect only the config digest.This updates the assertion to accept either digest, so the test passes on both old and new Docker versions.