Skip to content

Fix Docker image ID test for Docker 29#1633

Merged
JamieMagee merged 1 commit intomainfrom
fix/docker-29-image-id-test
Feb 18, 2026
Merged

Fix Docker image ID test for Docker 29#1633
JamieMagee merged 1 commit intomainfrom
fix/docker-29-image-id-test

Conversation

@JamieMagee
Copy link
Member

GitHub Actions runners were updated to Docker 29.1.x on February 9. Docker 29 makes the containerd image store the default for fresh installs, which changes how image IDs are reported.

With the legacy graphdriver, docker inspect returned the config digest as the image ID. With the containerd image store, it returns the manifest digest instead. The test image hasn't changed -- both digests are valid for it -- but DockerService_PopulatesBaseImageAndLayerDetailsAsync was hardcoded to expect only the config digest.

This updates the assertion to accept either digest, so the test passes on both old and new Docker versions.

Copilot AI review requested due to automatic review settings February 18, 2026 01:14
@JamieMagee JamieMagee requested a review from a team as a code owner February 18, 2026 01:14
@JamieMagee JamieMagee requested review from VXianOng and removed request for Copilot February 18, 2026 01:14
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.7%. Comparing base (a8222d2) to head (aec04e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1633   +/-   ##
=====================================
  Coverage   90.7%   90.7%           
=====================================
  Files        444     444           
  Lines      39709   39710    +1     
  Branches    2418    2418           
=====================================
+ Hits       36029   36031    +2     
  Misses      3187    3187           
+ Partials     493     492    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JamieMagee
Copy link
Member Author

Verification test failures are expected. We are comparing the output from Docker 29, with the old, cached, output from an earlier version of Docker. The verification test output will be updated and cached with Docker 29 after merge to main.

@JamieMagee JamieMagee merged commit 70e02a0 into main Feb 18, 2026
26 of 27 checks passed
@JamieMagee JamieMagee deleted the fix/docker-29-image-id-test branch February 18, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants